From 6025212e93d9eaf87e9573402de493c37c888fae Mon Sep 17 00:00:00 2001
From: "theis.gaedigk" <theis.gaedigk@icloud.com>
Date: Wed, 20 Aug 2025 00:25:35 +0200
Subject: [PATCH] refactor: remove redundant environment variable validation
 and connection check in database service fix: update dependency reference for
 backend service in docker-compose

---
 backend/services/database.js | 26 --------------------------
 docker-compose.yml           |  2 +-
 2 files changed, 1 insertion(+), 27 deletions(-)

diff --git a/backend/services/database.js b/backend/services/database.js
index e53edf5..8b6beb2 100644
--- a/backend/services/database.js
+++ b/backend/services/database.js
@@ -1,42 +1,16 @@
 import mysql from "mysql2";
 import dotenv from "dotenv";
-import dns from "dns/promises";
 dotenv.config();
 
-// Validate required envs early
-const required = ["DB_HOST", "DB_USER", "DB_PASSWORD", "DB_NAME"];
-for (const k of required) {
-  if (!process.env[k]) {
-    throw new Error(`Missing required env var: ${k}`);
-  }
-}
-
 const pool = mysql
   .createPool({
     host: process.env.DB_HOST,
     user: process.env.DB_USER,
     password: process.env.DB_PASSWORD,
     database: process.env.DB_NAME,
-    waitForConnections: true,
-    connectionLimit: 10,
-    queueLimit: 0,
   })
   .promise();
 
-// Optional: resolve host and test a connection at startup for clearer errors
-(async () => {
-  try {
-    await dns.lookup(process.env.DB_HOST);
-    const conn = await pool.getConnection();
-    conn.release();
-  } catch (e) {
-    console.error(
-      `Database connectivity check failed for host "${process.env.DB_HOST}":`,
-      e.code || e.message
-    );
-  }
-})();
-
 export const loginFunc = async (username, password) => {
   const [result] = await pool.query(
     "SELECT * FROM users WHERE username = ? AND password = ?",
diff --git a/docker-compose.yml b/docker-compose.yml
index b9ff731..db89878 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -26,7 +26,7 @@ services:
       DB_PASSWORD: ${DB_PASSWORD}
       DB_NAME: borrow_system
     depends_on:
-      - mysql
+      - borrow_system-mysql
     volumes:
       - ./backend:/borrow_system-backend
     restart: unless-stopped