fix: update error response status and improve success message handling in weather fetching

- It works!

README.md

@@ -1,95 +1,15 @@
 # Weather App
 
-This is a simple weather application that allows users to view current weather data for a specified location. The app is built using React and TypeScript, and it fetches weather data from an external API.
+This version is only meant for publishing on the web. It is not meant for local development or use.
 
-> For that we use the OpenWeatherMap API. You can get your own API key by signing up at [OpenWeatherMap](https://openweathermap.org/api).
+You can find the web version of the Weather App at [https://weather.the1s.de](https://weather.the1s.de).
-
-## Features
-
-- Search for weather by city name
-- Display current weather conditions including temperature, humidity, and wind speed
-- Responsive design for mobile and desktop views
-- Change API key preferences
-- Display weather data in a user-friendly format
-
-## Installation
-### Prerequisites
-
-To install and run this application, you need the following tools:
-
-- Git (for cloning the repository)
-
-**and**
-
-- Node.js (v14 or higher)
-- npm (Node Package Manager)
-
-**or**
-
-- Docker (for running the app in a container)
-
-### 1st step - Get the source code
-**You can either clone the repository or download the latest release. Keep in mind that the cloned version may contain bugs.**
-1. Clone the repository:
-   ```bash
-   git clone https://git.the1s.de/theis.gaedigk/weather-app.git
-   ```
-
-**or**
-
-1. Download the latest release from the [releases page](https://git.the1s.de/theis.gaedigk/weather-app/releases/latest).
-2. Unzip the downloaded file to your desired location.
-
-#### 2nd step - Using Node.js and npm
-
-1. Navigate to the frontend project directory:
-   ```bash
-   cd weather-app/frontend
-   ```
-2. Install dependencies:
-   ```bash
-   npm install
-   ```
-3. Start the development server:
-   ```bash
-   npm run dev
-   ```
-4. Open your browser and go to `http://localhost:7002` to view the app.
-   **Note:** There is also a backend server directory, which is currently not in use. - You can ignore it for now.
-
-**or**
-
-#### 2nd step - Using Docker
-
-1. Navigate to the root path project directory:
-   ```bash
-   cd weather-app
-   ```
-2. Run in a Docker container:
-   ```bash
-   docker compose up -d --build
-   ```
-3. Open your browser and go to `http://localhost:7002` to view the app.
-   **Note:** There is also a backend server directory, which is currently not in use. - You can ignore it for now.
-
-## Usage
-
-1. Get an API key from [OpenWeatherMap](https://openweathermap.org/api).
-2. Click on the "Set API Key" button in the header to enter your API key.
-3. Enter a city name in the search bar and press Enter or click the "Get Weather" button.
-
-**Now you can view the current weather data for the specified city!**
-
-# Other Information
-
-## Technologies Used
-
-- React
-- TypeScript
-- Tailwind CSS
-- OpenWeatherMap API
-- Vite
 
 ## Version
 
-**On this branch (main) you will find the latest version of the weather app, which includes several improvements and bug fixes. But it is not yet fully functional. The app is still in development, and some features may not work as expected.**
+Currently hosted version: **development branch (latest)**
+
+## Dev info
+
+All changes that are made to this branch (`debian12`) will be automatically deployed to the [web version](https://weather.the1s.de) of the Weather App.
+
+This is done by using an auto pull script (`auto-pull.sh`) that runs on the server where the web version is hosted.

auto-pull.sh

@@ -0,0 +1,6 @@
+   #!/bin/bash
+   cd /pfad/zu/deinem/repo
+   while true; do
+     git pull || echo "git pull failed"
+     sleep 10
+   done

backend/routes/api.js

@@ -0,0 +1,63 @@
+import { Router } from "express";
+import dotenv from "dotenv";
+
+const router = Router();
+dotenv.config();
+
+router.get("/fetchWeather", async (req, res) => {
+  const city = req.query.city;
+  const units = req.query.units;
+  const apiKey = process.env.API_KEY;
+
+  try {
+    const locationResponse = await fetch(
+      `https://api.openweathermap.org/geo/1.0/direct?q=${city}&appid=${apiKey}`
+    );
+    if (!locationResponse.ok) {
+      return res.status(500).json({
+        error: "Error fetching location data. (Error: x32)",
+        success: "false",
+        data: null,
+      });
+    }
+    const location = await locationResponse.json();
+    if (!location || !location[0]) {
+      return res.status(404).json({
+        error: "Location not found.",
+        success: "false",
+        data: null,
+      });
+    }
+
+    const lat = location[0].lat;
+    const lon = location[0].lon;
+
+    const weatherResponse = await fetch(
+      `https://api.openweathermap.org/data/2.5/weather?lat=${lat}&lon=${lon}&appid=${apiKey}&units=${units}`
+    );
+
+    if (!weatherResponse.ok) {
+      return res.status(500).json({
+        error: "Unexpected error! (Error: x33)",
+        success: "false",
+        data: null,
+      });
+    }
+
+    const weather = await weatherResponse.json();
+
+    res.status(200).json({
+      error: "false",
+      success: "Weather data fetched successfully!",
+      data: weather,
+    });
+  } catch (err) {
+    res.status(500).json({
+      error: "Server error",
+      success: "false",
+      data: null,
+    });
+  }
+});
+
+export default router;

backend/server.js

@@ -1,7 +1,7 @@
 import express from "express";
 import cors from "cors";
-import env from "dotenv";
+import apiRouter from "./routes/api.js";
-env.config();
+
 const app = express();
 const port = 7001;
 
@@ -10,6 +10,8 @@ app.use(express.urlencoded({ extended: true }));
 app.set("view engine", "ejs");
 app.use(express.json());
 
+app.use("/api", apiRouter);
+
 app.get("/", (req, res) => {
   res.render("index.ejs", { title: port });
 });

backend/views/index.ejs

@@ -1,11 +1,12 @@
 <!DOCTYPE html>
 <html lang="en">
   <head>
-    <meta charset="UTF-8">
+    <meta charset="UTF-8" />
-    <meta name="viewport" content="width=device-width, initial-scale=1.0">
+    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <title>Backend | <%= title %></title>
   </head>
   <body>
-    You have reached the backend views index page.
+    <h1>You have reached the backend views index page!</h1>
+    <p>Currently, there is nothing to display!</p>
   </body>
 </html>

docker-compose.yml

@@ -1,20 +1,29 @@
 services:
   frontend:
-    container_name: frontend
+    container_name: weather-frontend
     build: ./frontend
     ports:
       - "7002:7002"
+    networks:
+      - proxynet
     environment:
       - CHOKIDAR_USEPOLLING=true
     volumes:
       - ./frontend:/app
       - /app/node_modules
     restart: unless-stopped
-#  backend:
+  backend:
-#   container_name: backend
+    container_name: weather-backend
-#  build: ./backend
+    build: ./backend
-# ports:
+    networks:
-#  - "7001:7001"
+      - proxynet
-#volumes:
+    ports:
-#  - ./backend:/bikelane-backend
+      - "7001:7001"
-# restart: unless-stopped
+    volumes:
+      - ./backend:/app
+      - /app/node_modules
+    restart: unless-stopped
+
+networks:
+  proxynet:
+    external: true

frontend/src/components/ChangePreferences.tsx

@@ -47,7 +47,7 @@ const ChangePreferences: React.FC<Props> = ({ onClose }) => {
             Temperature Unit
           </label>
           <select
-            className="w-full border-2 border-blue-200 rounded-lg px-4 py-2 focus:outline-none focus:ring-2 focus:ring-blue-400 transition"
+            className="cursor-pointer w-full border-2 border-blue-200 rounded-lg px-4 py-2 focus:outline-none focus:ring-2 focus:ring-blue-400 transition"
             value={unit}
             onChange={(e) => setUnit(e.target.value)}
           >
@@ -58,12 +58,12 @@ const ChangePreferences: React.FC<Props> = ({ onClose }) => {
         </div>
         {/* Theme */}
         <div>
-          <label className="block text-sm font-semibold text-gray-700 mb-2 items-center gap-2">
+          <label className="cursor-pointer block text-sm font-semibold text-gray-700 mb-2 items-center gap-2">
             <SunMoon />
             Theme
           </label>
           <select
-            className="w-full border-2 border-blue-200 rounded-lg px-4 py-2 focus:outline-none focus:ring-2 focus:ring-blue-400 transition"
+            className="cursor-pointer w-full border-2 border-blue-200 rounded-lg px-4 py-2 focus:outline-none focus:ring-2 focus:ring-blue-400 transition"
             value={theme}
             onChange={(e) => setTheme(e.target.value)}
           >
@@ -77,7 +77,7 @@ const ChangePreferences: React.FC<Props> = ({ onClose }) => {
         {/* Submit */}
         <button
           type="submit"
-          className="w-full bg-gradient-to-r from-blue-600 to-blue-400 text-white py-3 rounded-xl font-bold text-lg shadow-lg hover:from-blue-700 hover:to-blue-500 transition-all focus:outline-none focus:ring-2 focus:ring-blue-400"
+          className="cursor-pointer w-full bg-gradient-to-r from-blue-600 to-blue-400 text-white py-3 rounded-xl font-bold text-lg shadow-lg hover:from-blue-700 hover:to-blue-500 transition-all focus:outline-none focus:ring-2 focus:ring-blue-400"
         >
           Save Preferences
         </button>

frontend/src/components/Header.tsx

@@ -1,6 +1,7 @@
 import React from "react";
 import ChangeAPI from "./ChangeAPI";
 import ChangePreferences from "./ChangePreferences";
+import { myToast } from "../utils/toastify";
 import { useState } from "react";
 import Cookies from "js-cookie";
 import logo from "../assets/cloud-sun-fill.png";
@@ -21,15 +22,15 @@ const Header: React.FC = () => {
             className="w-10 h-10 drop-shadow-lg"
           />
           <h1 className="text-4xl font-extrabold tracking-wide drop-shadow-lg">
-            Weather App
+            Weather App - <strong>Web</strong>
           </h1>
         </div>
         <div className="flex items-center gap-4">
           {" "}
           {/* Added container for buttons */}
           <button
-            className="bg-white text-blue-700 font-bold px-6 py-3 rounded-xl shadow-lg hover:bg-blue-100 transition-all border border-blue-200 flex items-center gap-2"
+            className="bg-gray-200 text-gray-400 font-bold px-6 py-3 rounded-xl shadow-lg border border-gray-300 flex items-center gap-2 cursor-not-allowed opacity-60"
-            onClick={() => setApiCard(true)}
+            onClick={() => myToast("You don't need to set an API Key!", "info")}
           >
             <span className="flex items-center gap-2">
               <KeyRound />
@@ -37,7 +38,7 @@ const Header: React.FC = () => {
             </span>
           </button>
           <button
-            className="bg-white text-blue-700 font-bold px-6 py-3 rounded-xl shadow-lg hover:bg-blue-100 transition-all border border-blue-200 flex items-center gap-2"
+            className="cursor-pointer bg-white text-blue-700 font-bold px-6 py-3 rounded-xl shadow-lg hover:bg-blue-100 transition-all border border-blue-200 flex items-center gap-2"
             onClick={() => setPreferencesCard(true)}
           >
             <span className="flex items-center gap-2">
@@ -50,7 +51,7 @@ const Header: React.FC = () => {
             target="_blank"
             rel="noopener noreferrer"
           >
-            <button className="bg-white text-blue-700 font-bold px-6 py-3 rounded-xl shadow-lg hover:bg-blue-100 transition-all border border-blue-200 flex items-center gap-2">
+            <button className="cursor-help bg-white text-blue-700 font-bold px-6 py-3 rounded-xl shadow-lg hover:bg-blue-100 transition-all border border-blue-200 flex items-center gap-2">
               <span className="flex items-center gap-2">
                 <Github /> Docs
               </span>

frontend/src/components/WeatherData.tsx

@@ -1,5 +1,6 @@
 import React from "react";
 import { Sunrise, Sunset } from "lucide-react";
+import { getDateTime } from "../utils/utils";
 
 const WeatherData: React.FC = () => {
   const weatherRaw = localStorage.getItem("weather");
@@ -75,6 +76,11 @@ const WeatherData: React.FC = () => {
                 : "--:--"}
             </span>
           </div>
+          <div className="flex items-center gap-3">
+            <span className="text-base text-gray-600 italic font-semibold">
+              Last updated: {getDateTime()}
+            </span>
+          </div>
         </div>
       </div>
     </div>

frontend/src/components/WeatherForm.tsx

@@ -1,7 +1,6 @@
 import React from "react";
 import { useState } from "react";
 import { fetchWeather } from "../utils/apiFunc";
-import Cookies from "js-cookie";
 import { toast } from "react-toastify";
 import WeatherData from "./WeatherData";
 import { useEffect } from "react";
@@ -9,9 +8,7 @@ import { X } from "lucide-react";
 
 const WeatherCard: React.FC = () => {
   const [city, setCity] = useState("");
-  const [loading, setLoading] = useState(false);
   const [weatherData, setWeatherData] = useState(false);
-  const getAPIKey = () => Cookies.get("apiKey") || "";
   const getUnit = () => localStorage.getItem("unit") || "metric";
 
   const handleCityChange = (event: React.ChangeEvent<HTMLInputElement>) => {
@@ -20,13 +17,10 @@ const WeatherCard: React.FC = () => {
 
   const handleSubmit = async (event: React.FormEvent<HTMLFormElement>) => {
     event.preventDefault();
-    setLoading(true);
+    setWeatherData(false);
     toast
-      .promise(fetchWeather(city, getAPIKey(), getUnit()), {
+      .promise(fetchWeather(city, getUnit()), {
         pending: "Fetching weather data...",
-        success: "Weather data loaded successfully!",
-        error:
-          "Failed to load weather data. Please check your entered city name. (Error: x4040)",
       })
       .then(() => {
         if (localStorage.getItem("weather")) {
@@ -34,7 +28,6 @@ const WeatherCard: React.FC = () => {
         } else {
           setWeatherData(false);
         }
-        setLoading(false);
       });
   };
 
@@ -55,6 +48,9 @@ const WeatherCard: React.FC = () => {
       <p className="mb-2 text-gray-600">
         Current weather will be displayed here.
       </p>
+      <p className="mb-2 text-gray-600">
+        <strong>You don't need an API Key!</strong>
+      </p>
       <form onSubmit={handleSubmit} className="flex flex-col gap-4 mt-4">
         <label htmlFor="city" className="font-medium text-gray-700">
           Enter City:
@@ -69,10 +65,10 @@ const WeatherCard: React.FC = () => {
           required
           className="border border-blue-300 rounded-xl px-4 py-3 focus:outline-none focus:ring-2 focus:ring-blue-400 bg-blue-50 text-blue-900 font-mono"
         />
-        <div className="flex items-center gap-2">
+        <div className="cursor-pointer flex items-center gap-2">
           <button
             type="submit"
-            className="flex-1 bg-gradient-to-r from-blue-600 to-blue-400 text-white font-bold px-4 py-3 rounded-xl shadow-lg hover:from-blue-700 hover:to-blue-500 transition-all"
+            className="cursor-pointer flex-1 bg-gradient-to-r from-blue-600 to-blue-400 text-white font-bold px-4 py-3 rounded-xl shadow-lg hover:from-blue-700 hover:to-blue-500 transition-all"
           >
             Get Weather
           </button>
@@ -83,7 +79,7 @@ const WeatherCard: React.FC = () => {
                 setWeatherData(false);
                 localStorage.removeItem("weather");
               }}
-              className="flex-shrink-0 bg-red-500 hover:bg-red-600 text-white rounded-xl p-3 shadow-lg transition-colors duration-200 focus:outline-none focus:ring-2 focus:ring-red-400"
+              className="cursor-pointer flex-shrink-0 bg-red-500 hover:bg-red-600 text-white rounded-xl p-3 shadow-lg transition-colors duration-200 focus:outline-none focus:ring-2 focus:ring-red-400"
               aria-label="Close weather data"
             >
               <X />

frontend/src/utils/apiFunc.ts

@@ -1,36 +1,31 @@
 import { myToast } from "./toastify";
-import Cookies from "js-cookie";
 
-export const fetchWeather = async (
+export const fetchWeather = async (city: string, units: string) => {
-  city: string,
+  try {
-  apiKey: string,
+    const response = await fetch(
-  units: string
+      `https://backend.weather.the1s.de/api/fetchWeather?city=${encodeURIComponent(
-) => {
+        city
-  // Get location data
+      )}&units=${encodeURIComponent(units)}`,
-  const location = await fetch(
+      {
-    `http://api.openweathermap.org/geo/1.0/direct?q=${city}&appid=${apiKey}`
+        method: "GET",
-  ).then((response) => {
+        headers: {
-    if (response.status === 401) {
+          "Content-Type": "application/json",
-      if (Cookies.get("apiKey") === undefined || Cookies.get("apiKey") === "") {
+        },
-        myToast("You have to enter an API key!", "error");
+      }
-      } else {
-        myToast(
-          "You are not authorized to access this resource. Please check your API key. (Error: x4010)",
-          "error"
     );
-      }
-    } else if (response.ok) {
-      return response.json();
-    } else {
-      myToast("Error fetching location data. (Error: x32)", "error");
-    }
-  });
-  const lat = location[0].lat;
-  const lon = location[0].lon;
 
-  // Get weather data
+    const responseData = await response.json();
-  const weather = await fetch(
+
-    `https://api.openweathermap.org/data/2.5/weather?lat=${lat}&lon=${lon}&appid=${apiKey}&units=${units}`
+    if (!response.ok) {
-  ).then((response) => response.json());
+      myToast(responseData.error, "error");
-  localStorage.setItem("weather", JSON.stringify(weather));
+      return;
+    }
+    localStorage.setItem("weather", JSON.stringify(responseData.data));
+    myToast(responseData.success, "success");
+    return;
+  } catch (error) {
+    const errorMsg = JSON.stringify(error);
+    myToast(errorMsg, "error");
+    return null;
+  }
 };

frontend/src/utils/utils.ts

@@ -0,0 +1,24 @@
+export const getDateTime = () => {
+  const now = new Date();
+  const day = now.getDate();
+  const month = now.toLocaleString("en-GB", { month: "long" });
+  const hours = now.getHours().toString().padStart(2, "0");
+  const minutes = now.getMinutes().toString().padStart(2, "0");
+
+  // Ordinal suffix
+  const getOrdinal = (n: number) => {
+    if (n > 3 && n < 21) return "th";
+    switch (n % 10) {
+      case 1:
+        return "st";
+      case 2:
+        return "nd";
+      case 3:
+        return "rd";
+      default:
+        return "th";
+    }
+  };
+
+  return `${day}${getOrdinal(day)} ${month}, ${hours}:${minutes}`;
+};